[CustomerBundle][Customer] Introduce Customer component and CustomerBundle #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Jul 20, 2016
•
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | - |
| License | MIT |
| CHANGELOG | ||
| ========= | ||
|
|
||
| ### v0.19.0 |
There was a problem hiding this comment.
We're v1.0.0-alpha.1 now 😉
pjedrzejewski
added
the
BC Break
| MIT License | ||
| ----------- | ||
|
|
||
| License can be found [here](https://github.com/Sylius/User/blob/master/LICENSE). |
tuka217
force-pushed
the
customer-user
branch
2 times, most recently
from
bb204b3 to
ad56d93
Compare
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| use Doctrine\Common\Collections\ArrayCollection; | |||
| use Sylius\Component\Customer\Model\Customer as BaseCustomer; | |||
| use Sylius\Component\User\Model\UserAwareInterface; | |||
There was a problem hiding this comment.
Not used here.
tuka217
force-pushed
the
customer-user
branch
8 times, most recently
from
e405e03 to
b9cd59b
Compare
| @@ -20,7 +20,7 @@ letters. Example usage: | |||
| // directory, relative to this file | |||
| require_once __DIR__.'/../vendor/autoload.php'; | |||
|
|
|||
| use Sylius\Component\User\Model\Customer; | |||
| use Sylius\Component\Customer\Model\Customer; | |||
There was a problem hiding this comment.
There is no Customer in User component anymore, so we should update the whole snippet and use only User :)
[CoreBundle] Fix broken 'use'
…ion and CustomerRegistration type to Core with all related classes from CustomerBundle and UserBundle
…fix services.xml in UserBundle and CustomerBundle
[UserBundle] Move function which has connection between user and customer to core UserRepository
[Core] Add reference to customer component in composer [UserBundle] Remove CanonicalizerListener, CustomerAwareListener, remove core connnections [CustomerBundle] Add missing reference to doctrine/orm in composer, add CustomerAwareListener
[CoreBundle] Add PasswordUpdaterListener, UserRegistrationListener
[UserBundle] remove routing
… group and gender from UserBundle
tuka217
force-pushed
the
customer-user
branch
2 times, most recently
from
8c8a083 to
2c44817
Compare
[CustomerBundle] remove CustomerAwareListener
|
Great job Ania! 👍 |
|
|
||
| $container | ||
| ->getDefinition('sylius.listener.password_updater') | ||
| ->setClass('Sylius\Bundle\CoreBundle\EventListener\PasswordUpdaterListener'); |
There was a problem hiding this comment.
Should not be hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.