[Order] Fix number generator #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jul 21, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
pjedrzejewski
added
the
Enhancement
GSadee
force-pushed
the
order-generator-fixes
branch
from
7705351 to
9ac8d88
Compare
|
👍 |
| * @return string | ||
| */ | ||
| public function generate(); | ||
| public function generate(OrderInterface $order); |
There was a problem hiding this comment.
Why did you do this? It is just a generator and it does not care about an order itself.
There was a problem hiding this comment.
You may want to generate order number based on: channel code, date, customer group... whatever. This gives us access to all info about the order. Otherwise we have 0.
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Order] Fix number generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.