Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Factory] Decouple ProductVariantFactory and CouponFactory from repositories #5697

Merged

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets
License MIT

Thanks to #5559 we are able to decouple factories from repositories 🎉

@lchrusciel lchrusciel changed the title [Product] Decouple ProductVariantFactory from repository [Product] Decouple ProductVariantFactory and CouponFactory from repositories Aug 4, 2016
@lchrusciel lchrusciel changed the title [Product] Decouple ProductVariantFactory and CouponFactory from repositories [Factory] Decouple ProductVariantFactory and CouponFactory from repositories Aug 4, 2016
@lchrusciel lchrusciel force-pushed the decouple-product-variant-factory branch from 9af99ab to 055d163 Compare August 4, 2016 08:14
@lchrusciel lchrusciel force-pushed the decouple-product-variant-factory branch from 055d163 to f2dcbf0 Compare August 4, 2016 08:16
@pjedrzejewski pjedrzejewski merged commit 8f2e06c into Sylius:master Aug 4, 2016
@pjedrzejewski
Copy link
Member

Thanks Łukasz!

@lchrusciel lchrusciel deleted the decouple-product-variant-factory branch August 4, 2016 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants