[Core][Cart] Cart locale update #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Aug 29, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | #5813 |
| License | MIT |
| I want to be able to see order currency on the order summary page | ||
|
|
||
| Background: | ||
| Given the store operates on a single channel in "France" |
There was a problem hiding this comment.
Didn't we change this steps to meet a default shop configuration?
There was a problem hiding this comment.
Yes we did but right now this feature is in progress. Or it has been already done.
Arminek
changed the title
pjedrzejewski
added
BC Break
Arminek
force-pushed
the
cart-locale-update
branch
from
591672e to
01d5c83
Compare
Arminek
changed the title
| @@ -222,7 +247,8 @@ protected function getDefinedElements() | |||
| */ | |||
| private function getCountryNameOrDefault($code) | |||
| { | |||
| $countryName = null === $code ? 'Select' : Intl::getRegionBundle()->getCountryNames('en')[$code]; | |||
| $displayLocale = $this->localeContext->getLocaleCode(); | |||
There was a problem hiding this comment.
We should not depend on context here, the locale should be passed as an argument.
Arminek
force-pushed
the
cart-locale-update
branch
from
01d5c83 to
9270a36
Compare
| $this->cartManager->persist($cart); | ||
| $this->cartManager->flush(); | ||
| } catch (CartNotFoundException $exception) { | ||
| throw new HandleException(self::class, 'Sylius was unable to found cart.', $exception); |
There was a problem hiding this comment.
Shouldn't the "found" be in infinitive form?
Arminek
force-pushed
the
cart-locale-update
branch
2 times, most recently
from
25f9034 to
31a7ebe
Compare
| </service> | ||
| </services> | ||
|
|
||
| </container> |
Arminek
force-pushed
the
cart-locale-update
branch
from
31a7ebe to
1b06b2c
Compare
|
Great job Arek! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Core][Cart] Cart locale update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.