-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Behat] Checked if the shipment confirmation email gets sent #5932
[Behat] Checked if the shipment confirmation email gets sent #5932
Conversation
@ui @email | ||
Scenario: Receiving a welcoming email after registration | ||
When I register with email "[email protected]" and password "suitsarelife" | ||
Then I should be notified that new account has been successfully created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with my account
as it's an I register
scenario. WDYT?
ccca80c
to
387e00e
Compare
Scenario: Finalizing order's shipment | ||
Given I view the summary of the order "#00000666" | ||
When specify its tracking code as "#00044" | ||
And I ship this order | ||
Then I should be notified that the order's shipment has been successfully shipped | ||
Then I should be notified that the order has been successfully shipped | ||
And an email with shipment's details of order "#00000666" should be sent to "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... of this order "# 00000666" ...
387e00e
to
0680b7e
Compare
$this->assertEmailContainsMessage($order->getLastShipment()->getMethod()->getName()); | ||
|
||
$tracking = $this->sharedStorage->get('tracking_code'); | ||
$this->assertEmailContainsMessage($tracking); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could squash it to the single check? Your order %number% has been shipped using %method%. You can check it's location with the "%tracking%" tracking code.
Nice work Janek! Please apply my comments in a separate PR. |
Based on #5912