[BugFix][Core] Added shipping method eligibility checker to core methods resolver #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +52,7 @@ function it_implements_shipping_methods_by_zones_and_channel_resolver_interface( | |||
| } | |||
|
|
|||
| function it_returns_shipping_methods_matched_for_shipment_order_shipping_address_and_order_channel( | |||
| $eligibilityChecker, | |||
There was a problem hiding this comment.
Could you please use type hints also for constructor dependencies mocks?
There was a problem hiding this comment.
Oh I didn't know that was possible, nice!
|
Ready. |
|
Thank you Steffen! We should add scenarios for this functionality as it has not been migrated from the "legacy" properly. |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…methods-resolver [BugFix][Core] Added shipping method eligibility checker to core methods resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for shipping method eligibility when getting shipping methods based on zone and channel.