[Repository] Removed unused createFilterPaginator methods
#6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Sep 21, 2016
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
michalmarcinkowski
added
Deprecation
BC Break
| * @param array $sorting | ||
| * | ||
| * @return PagerfantaInterface | ||
| */ | ||
| public function createCheckoutsPaginator(array $criteria = null, array $sorting = null); |
There was a problem hiding this comment.
How about other ...Paginator methods? Are they used anywhere? If not we should remove them also.
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function findForDetailsPage($id) |
There was a problem hiding this comment.
Such methods are also remains from WebBundle, please look through the codebase to catch as much unused repository methods as possible ;)
There was a problem hiding this comment.
This method also :)
| @@ -39,15 +39,6 @@ public function createByTaxonPaginator(TaxonInterface $taxon, array $criteria = | |||
| * @return PagerfantaInterface | |||
| */ | |||
| public function createByTaxonAndChannelPaginator(TaxonInterface $taxon, ChannelInterface $channel); | |||
There was a problem hiding this comment.
Should be removed also :)
Zales0123
force-pushed
the
remove-unused-repository-methods
branch
6 times, most recently
from
3c7e69c to
cb16792
Compare
|
@Zales0123 rebase please :) |
Zales0123
force-pushed
the
remove-unused-repository-methods
branch
2 times, most recently
from
47321b5 to
3b271c6
Compare
Zales0123
force-pushed
the
remove-unused-repository-methods
branch
from
3b271c6 to
8da517b
Compare
|
👍 |
|
Hi! What methods should be used instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.