Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Fix admin without a slash sufix path #6252

Merged
merged 1 commit into from
Oct 1, 2016
Merged

[Admin] Fix admin without a slash sufix path #6252

merged 1 commit into from
Oct 1, 2016

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets fixes #6168 comment
License MIT

Basic redirect

dashboard redirect

@pamil
Copy link
Contributor

pamil commented Sep 30, 2016

Can we add some tests to avoid regressions?

@lchrusciel
Copy link
Member Author

How do you want to test this? It is just a redirect loop and any other redirect loop was tested. Feel free to help me with it.

@emodric emodric mentioned this pull request Sep 30, 2016
Merged
@pjedrzejewski pjedrzejewski merged commit 93323a5 into Sylius:master Oct 1, 2016
@pjedrzejewski
Copy link
Member

Thanks Łukasz!

@lchrusciel lchrusciel deleted the fix-admin-path branch October 1, 2016 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When not "admin-logged", /admin redirects to /login
3 participants
@lchrusciel @pamil @pjedrzejewski