Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][Book] Product Associations #6570

Merged
merged 2 commits into from
Oct 31, 2016

Conversation

CoderMaggie
Copy link
Member

Q A
Doc fix? no
New docs? yes
BC breaks? no
Related tickets partially #5275
License MIT

@michalmarcinkowski michalmarcinkowski added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 27, 2016
Product Associations
====================

Associations of products can be used as a marketing tool ofr suggesting your customers, what products to buy together with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofr -> for

/** @var ProductAssociationInterface $association */
$association = $this->container->get('sylius.factory.product_association')->createNew();

$association->setType($associationType);
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski Oct 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add also
$associationType = $this->container->get('sylius.repository.product_association_type')->findOneBy(['code' => 'accessories']);

@CoderMaggie CoderMaggie force-pushed the docs/book/associations branch from f1844ba to 18a3411 Compare October 28, 2016 07:43
@pjedrzejewski pjedrzejewski merged commit b20109e into Sylius:master Oct 31, 2016
@pjedrzejewski
Copy link
Member

Thanks Magda, nice work!

@CoderMaggie CoderMaggie deleted the docs/book/associations branch January 17, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants