[Core][Promotion] Unify taxon rule checkers #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
BC Break
pamil
approved these changes
Nov 16, 2016
Zales0123
changed the title
Zales0123
force-pushed
the
unify-taxon-rule-checkers
branch
from
1733dc7 to
4f4e71f
Compare
Arminek
approved these changes
Nov 16, 2016
| @@ -26,15 +26,6 @@ Feature: Receiving a discount based on a configured promotion | |||
| And my discount should be "-$10.00" | |||
|
|
|||
| @ui | |||
| Scenario: Receiving a discount on products from a specific taxon if an order contains products from an another taxon | |||
There was a problem hiding this comment.
That scenario should work with HasTaxonRule, we shouldn't to remove it :)
tuka217
reviewed
Nov 16, 2016
| @@ -120,9 +120,6 @@ sylius: | |||
| product_association_type: | |||
| name: Name | |||
| promotion_rule: | |||
| contains_taxon: | |||
| taxon: Taxon | |||
| count: Count | |||
| taxon: | |||
There was a problem hiding this comment.
shouldn't it be now has_taxon?
GSadee
requested changes
Nov 16, 2016
| @@ -143,22 +143,12 @@ public function iAddIt() | |||
| } | |||
|
|
|||
| /** | |||
| * @Given I add the "Contains number of items from taxon" rule configured with :count :taxonName | |||
| * @Given I add the "Has at least one from taxons" rule configured with :firstTaxon | |||
| * @Given I add the "Has at least one from taxons" rule configured with :firstTaxon and :secondTaxon | |||
There was a problem hiding this comment.
Shouldn't these steps start from @When ?
|
Thanks Mateusz, please apply all comments in a separate PR. |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Core][Promotion] Unify taxon rule checkers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we decided to keep only one, simpler rule, which checks is there any product from one of picked taxons. The other one (with count) could be easily implemented if needed. I'm also not 100% about new rule checker name, so I'd be glad to see any feedback about that.