Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bundles] Services initialization tests #6811

Merged
merged 33 commits into from
Nov 29, 2016

Conversation

CoderMaggie
Copy link
Member

@CoderMaggie CoderMaggie commented Nov 22, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets
License MIT

We've assumed it will be wise to write a test that checks if all services are initializable.

Doing it in the other bundles too!

@CoderMaggie CoderMaggie force-pushed the bundles-services-test branch 3 times, most recently from 997a6c3 to 3ad6123 Compare November 22, 2016 13:21
@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 22, 2016
@CoderMaggie CoderMaggie changed the title [AddressingBundle] Services initialization test [WIP][Bundles] Services initialization tests Nov 22, 2016

new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
new Symfony\Bundle\TwigBundle\TwigBundle(),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra blank line

@CoderMaggie CoderMaggie force-pushed the bundles-services-test branch 15 times, most recently from b212414 to 248961b Compare November 29, 2016 15:01
@CoderMaggie CoderMaggie force-pushed the bundles-services-test branch from 248961b to ff3e4cc Compare November 29, 2016 15:10
@CoderMaggie CoderMaggie changed the title [WIP][Bundles] Services initialization tests [Bundles] Services initialization tests Nov 29, 2016
@pjedrzejewski pjedrzejewski merged commit a6ff925 into Sylius:master Nov 29, 2016
@pjedrzejewski
Copy link
Member

Thank you Magda, great work! :)

@CoderMaggie CoderMaggie deleted the bundles-services-test branch January 17, 2017 10:59
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants