-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bundles] Services initialization tests #6811
Merged
pjedrzejewski
merged 33 commits into
Sylius:master
from
CoderMaggie:bundles-services-test
Nov 29, 2016
Merged
[Bundles] Services initialization tests #6811
pjedrzejewski
merged 33 commits into
Sylius:master
from
CoderMaggie:bundles-services-test
Nov 29, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderMaggie
force-pushed
the
bundles-services-test
branch
3 times, most recently
from
November 22, 2016 13:21
997a6c3
to
3ad6123
Compare
pjedrzejewski
added
the
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
label
Nov 22, 2016
CoderMaggie
changed the title
[AddressingBundle] Services initialization test
[WIP][Bundles] Services initialization tests
Nov 22, 2016
|
||
new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(), | ||
new Symfony\Bundle\TwigBundle\TwigBundle(), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra blank line
CoderMaggie
force-pushed
the
bundles-services-test
branch
15 times, most recently
from
November 29, 2016 15:01
b212414
to
248961b
Compare
CoderMaggie
force-pushed
the
bundles-services-test
branch
from
November 29, 2016 15:10
248961b
to
ff3e4cc
Compare
8 tasks
CoderMaggie
changed the title
[WIP][Bundles] Services initialization tests
[Bundles] Services initialization tests
Nov 29, 2016
Thank you Magda, great work! :) |
This was referenced Nov 29, 2016
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Bundles] Services initialization tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've assumed it will be wise to write a test that checks if all services are initializable.
Doing it in the other bundles too!