-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Currency] [Critical] Channel based currencies support #6901
Merged
michalmarcinkowski
merged 66 commits into
Sylius:master
from
lchrusciel:rebased-currency-party
Nov 28, 2016
Merged
[Currency] [Critical] Channel based currencies support #6901
michalmarcinkowski
merged 66 commits into
Sylius:master
from
lchrusciel:rebased-currency-party
Nov 28, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
changed the title
[Currency] [RFC] [Critical] Channel based currencies support
[Currency] [Critical] Channel based currencies support
Nov 28, 2016
michalmarcinkowski
added
BC Break
PRs introducing BC breaks (do not even try to merge).
Bug Fix
Critical
Issues and PRs, which are critical and should be fixed ASAP.
labels
Nov 28, 2016
pamil
reviewed
Nov 28, 2016
@@ -14,7 +14,7 @@ | |||
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
<services> | |||
<service id="sylius.form.type.security_login" class="Sylius\Bundle\UiBundle\Form\Type\SecurityLoginType"> | |||
<tag name="form.type" /> | |||
<tag name="form.type" alias="sylius_security_login" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurr durr 🌮
lchrusciel
force-pushed
the
rebased-currency-party
branch
6 times, most recently
from
November 28, 2016 17:37
15cb723
to
566b158
Compare
…nd OrderExchangeRateUpdater
lchrusciel
force-pushed
the
rebased-currency-party
branch
from
November 28, 2016 17:57
566b158
to
4540986
Compare
lchrusciel
force-pushed
the
rebased-currency-party
branch
from
November 28, 2016 18:22
4540986
to
c037903
Compare
Awesome job guys! 👍 👍 👍 🎉 |
It is not over yet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and fixed version of #6868
Contains also #6896