[Core] Maintain previous cart after logging in #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
maintain-previous-cart-after-logging-in
branch
4 times, most recently
from
89f7677 to
24780d2
Compare
| try { | ||
| $channel = $this->channelContext->getChannel(); | ||
| } catch (ChannelNotFoundException $exception) { | ||
| return; |
There was a problem hiding this comment.
throw new CartNotFoundException?
| throw new CartNotFoundException('Sylius was not able to find the cart, as there is no logged in user.'); | ||
| } | ||
|
|
||
| $cart = $this->orderRepository->findLatestCartByChannelAndCustomer($channel, $customer); |
There was a problem hiding this comment.
We should return only one cart. Can't we use getOneOrNullResult?
There was a problem hiding this comment.
Well, sure we can! 🐃
Zales0123
force-pushed
the
maintain-previous-cart-after-logging-in
branch
from
5f322f0 to
98c4e53
Compare
|
Thank you Mateusz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two issues: