Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UiBundle] Semantic ui paginator #6922

Merged
merged 5 commits into from
Nov 29, 2016
Merged

[UiBundle] Semantic ui paginator #6922

merged 5 commits into from
Nov 29, 2016

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 29, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets fixes #6747
License MIT

@loic425 loic425 changed the title [UIBundle][WIP] Semantic ui paginator [UiBundle][WIP] Semantic ui paginator Nov 29, 2016
@pjedrzejewski pjedrzejewski added Bug Fix UX Issues and PRs aimed at improving User eXperience. labels Nov 29, 2016
@loic425 loic425 changed the title [UiBundle][WIP] Semantic ui paginator [UiBundle] Semantic ui paginator Nov 29, 2016
@loic425
Copy link
Member Author

loic425 commented Nov 29, 2016

@pjedrzejewski
@michalmarcinkowski
It's done :)

@pjedrzejewski pjedrzejewski merged commit 8c01194 into Sylius:master Nov 29, 2016
@pjedrzejewski
Copy link
Member

Thank you @loic425! Awesome work, hopefully we get upgrade to latest Pagerfanta for BETA2. :)

@loic425
Copy link
Member Author

loic425 commented Dec 14, 2016

@pjedrzejewski
Release is ok on pagerfanta, but not yet on pagerfanta bundle. This is a very slow process cause they don't have enough time. I don't know the release date for Sylius BETA2, but it's possible to start with upgrading pagerfanta component and remove it from sylius ui bundle and remove the translated view later...

@loic425 loic425 deleted the semantic_ui branch August 9, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UiBundle] display overflow on paginator with too many pages (v1.0.0-alpha1)
3 participants
@loic425 @pjedrzejewski @loicmobizel