Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fetch translation with symlink #108

Open
wants to merge 2 commits into
base: 2.3
Choose a base branch
from
Open

Conversation

Roshyo
Copy link

@Roshyo Roshyo commented Aug 19, 2021

Fixes #107

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main problem I have with this lib is that we lack the rule of thumb for testing it. I'm afraid to merge it, as I'm not familiar with its internals + we don't have a clear path for it.

I can only trust you, that it works. And I do, really. But for me it is not enough to make a merge

@Roshyo
Copy link
Author

Roshyo commented Apr 7, 2022

What would you recommend to ease the maintenance of this repo ?
Especially this use-case, I don't really know how to test a symlink in PHPUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation files are not fetched if symlink
2 participants