Allow installation with Symfony 7 #131
Conversation
alexander-schranz
force-pushed
the
feature/upgrade-symfony-7
branch
3 times, most recently
from
01abfcf to
a30c7b1
Compare
.github/workflows/build.yml
Outdated
| name: Remove analyse dependencies | ||
| run: | | ||
| composer remove vimeo/psalm --no-update | ||
| composer remove sylius-labs/coding-standard --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: SyliusLabs/CodingStandard#60
.github/workflows/build.yml
Outdated
| run: | | ||
| composer remove vimeo/psalm --no-update | ||
| composer remove sylius-labs/coding-standard --no-update | ||
| composer remove rector/rector --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: #132
.github/workflows/build.yml
Outdated
| run: composer update | ||
| name: Remove analyse dependencies | ||
| run: | | ||
| composer remove vimeo/psalm --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: #133
alexander-schranz
force-pushed
the
feature/upgrade-symfony-7
branch
from
d50bdde to
ce41b47
Compare
|
Hi @alexander-schranz! |
|
Hi @TheMilek. Can I help in any way to get this PR merged? |
alexander-schranz
force-pushed
the
feature/upgrade-symfony-7
branch
from
2ae84fb to
e09a5c3
Compare
|
@TheMilek rebased! |
|
Thank you, @alexander-schranz! |
Merged! 🚀 |
|
@TheMilek No problem thanks for the merge :) |
|
Looks like I missed changes in the ThemeCollector which where supressed by psalm annotation: #134 |
This will allow the usage of the Symfony Theme Bundle with Symfony 7. There are some blocking dev dependencies which I removed for testing Symfony 7, they are only required for the lint task so we can still make the Tests run on Symfony 7.
The changed methods should be no bc break as they are all part of final classes.