Skip to content

Commit

Permalink
refactor #49 Drop ECS 9.0 and change to new config syntax (Zales0123)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.0-dev branch.

Discussion
----------

I think I did not break anything 😅 🖖 

Commits
-------

e84342c Drop ECS 9.0 and change to new config syntax
  • Loading branch information
GSadee authored Jun 17, 2022
2 parents 242bc62 + e84342c commit 3505971
Show file tree
Hide file tree
Showing 4 changed files with 138 additions and 312 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
php: [8.0]
ecs: [10.*, 9.*]
ecs: [10.*, 11.*]

steps:
-
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ Installation & usage
2. Import the configuration file in your `ecs.php`:

```php
$containerConfigurator->import('vendor/sylius-labs/coding-standard/ecs.php');
$ecsConfig->import('vendor/sylius-labs/coding-standard/ecs.php');
```

Example config (ecs.php)
------------------------

```php
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\EasyCodingStandard\Config\ECSConfig;;
return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import('vendor/sylius-labs/coding-standard/ecs.php');
return static function (ECSConfig $ecsConfig): void {
$ecsConfig->import('vendor/sylius-labs/coding-standard/ecs.php');
};
```

Expand Down
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@
"require": {
"php": "^8.0",
"slevomat/coding-standard": "^7.0",
"symplify/easy-coding-standard": "^9.0 || ^10.0"
"symplify/easy-coding-standard": "^10.0 || ^11.0"
},
"conflict": {
"symplify/easy-coding-standard": ">=10.2.11",
"symplify/package-builder": "^8.3"
},
"autoload-dev": {
Expand Down
Loading

0 comments on commit 3505971

Please sign in to comment.