Add basic ci pipeline #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
reviewed
Jan 31, 2025
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.21 |
There was a problem hiding this comment.
Would go-version-file to go.mod be better? therefore tracking of go versions is in one single place and maintainers don't need to ensure that they're updating said action each time?
There was a problem hiding this comment.
Suggested change
| go-version: 1.21 | |
| go-version-file: "go.mod" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add github pipeline running build and go fmt (fail if code is not formatted correctly). Example of go fmt failure is here: https://github.com/fstaffa/synology-csi/actions/runs/7807003986/job/21294498642
Applied go fmt to all files