Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming #1697

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add streaming #1697

wants to merge 1 commit into from

Conversation

SamuelWei
Copy link
Collaborator

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

Copy link

cypress bot commented Dec 12, 2024

PILOS    Run #1914

Run Properties:  status check failed Failed #1914  •  git commit 25a17196dd: Add streaming
Project PILOS
Branch Review add-streaming
Run status status check failed Failed #1914
Run duration 04m 45s
Commit git commit 25a17196dd: Add streaming
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 26
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 529
View all changes introduced in this branch ↗︎

Tests for review

Failed  RoomsViewMeetings.cy.js • 22 failed tests • Frontend tests

View Output

Test Artifacts
Rooms view meetings > join running meeting Test Replay Screenshots
Rooms view meetings > join running meeting attendance logging Test Replay Screenshots
Rooms view meetings > join running meeting with recording Test Replay Screenshots
Rooms view meetings > join running meeting with recording without video Test Replay Screenshots
Rooms view meetings > join running meeting guests Test Replay Screenshots
Rooms view meetings > join running meeting guests errors Test Replay Screenshots
Rooms view meetings > join running meeting with access code Test Replay Screenshots
Rooms view meetings > join running meeting access code errors Test Replay Screenshots
Rooms view meetings > join running meeting token Test Replay Screenshots
Rooms view meetings > join running meeting token errors Test Replay Screenshots
The first 10 failed tests are shown, see all 22 tests in Cypress Cloud.
Failed  RoomsViewSettingsRoomTypeActions.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Rooms view settings > change room type with expert mode enabled Test Replay Screenshots
Failed  RoomsIndexCreateNewRoom.cy.js • 3 failed tests • Frontend tests

View Output

Test Artifacts
Rooms index create new room > create new room Test Replay Screenshots
Rooms index create new room > create new room errors Test Replay Screenshots
Rooms index create new room > cancel create new room Test Replay Screenshots

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 10.81081% with 297 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (8bc084e) to head (25a1719).

Files with missing lines Patch % Lines
...ces/js/components/RoomTabStreamingConfigButton.vue 0.00% 63 Missing ⚠️
...js/components/AdminStreamingRoomTypeEditButton.vue 0.00% 61 Missing ⚠️
resources/js/views/AdminStreamingSettings.vue 0.00% 58 Missing ⚠️
resources/js/components/RoomTabStreaming.vue 0.00% 46 Missing ⚠️
resources/js/components/AdminOverviewCard.vue 0.00% 23 Missing ⚠️
resources/js/components/RoomJoinButton.vue 9.09% 20 Missing ⚠️
resources/js/components/RoomTabSection.vue 72.72% 9 Missing ⚠️
resources/js/router.js 0.00% 8 Missing ⚠️
...rces/js/components/AdminStreamingRoomTypeTable.vue 0.00% 5 Missing ⚠️
resources/js/policies/StreamingPolicy.js 50.00% 2 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (8bc084e) and HEAD (25a1719). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (8bc084e) HEAD (25a1719)
20 17
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1697       +/-   ##
==============================================
- Coverage      96.42%   85.31%   -11.11%     
==============================================
  Files            364      164      -200     
  Lines           9586     4943     -4643     
  Branches         879      936       +57     
==============================================
- Hits            9243     4217     -5026     
- Misses           343      726      +383     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

coderabbitai bot commented Feb 6, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SamuelWei SamuelWei force-pushed the add-streaming branch 2 times, most recently from 8373de5 to 0b257c9 Compare February 7, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant