fix fail test run with enabled junit.testFilter option #1361
Conversation
Review: I think this is a safer way to do it. In the end, the error says "can't remove the root of a hierarchy", so it makes sense to exactly guard against this, and also it then only uses the general JUnit Platform API and doesn't rely on ArchUnit specifics (and `AbstractArchUnitTestDescriptor` is more an implementation detail, it's more by accident that the rule descriptors, etc., inherit from this, but the engine descriptor doesn't).
|
Thanks a lot for taking care of this! I do have one suggestion that I added as a fixup (see the commit message for the reasoning). In a nutshell, I think we can solve it a little safer by checking |
|
BTW: To get throught the CI commits also need a DCO sign-off in your commit message (see https://github.com/TNG/ArchUnit/blob/main/DCO#L34). If you're fine with that I could also add the line for you if you want 😉 |
|
Hi! I'm sorry for the long wait.
Thank you, I agree with your suggestion, it looks like more general decision
I would be very grateful to you. |
Hi! There is a problem if you enable the
junit.testFiltersetting, and there are other tests in the project besides arch-unitException:
In PR fix a condition so that non-ArchUnit descriptors are not checked
Tested the changes in my test repository https://github.com/Sparkymann/archunit-test
Failed workflow: https://github.com/Sparkymann/archunit-test/pull/1/checks
Corrected: https://github.com/Sparkymann/archunit-test/pull/3/checks