Js scss reformttings #167
Js scss reformttings #167
Conversation
CommanderStorm
force-pushed
the
js-scss-reformttings
branch
2 times, most recently
from
c6df327 to
f4e8bbc
Compare
There was a problem hiding this comment.
I have tried to look over all files. Sometimes the diff failed to understand the changes and hard to read, so I hope I haven't missed anything that it not reformatting.
There is only one thing that I think we need to keep, that is the navigatum.cloneState function instead of structuredClone, because Samsung Internet doesn't support it yet. Alternatively we could add a polyfill into core.js so that it is always available (even if polyfills.js is not loaded)
|
I noiced that the gulpfile has stopped processing spectre. I will look into this on monday :) |
Just to be sure, have you done npm update after the change in the package.json 😅 Edit: I see, sorry, same problem for me now. |
|
It was related to the |
CommanderStorm
force-pushed
the
js-scss-reformttings
branch
from
eb8460d to
f93cd61
Compare
Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
This is more consistent with the style used across most of the project Signed-off-by: Frank Elsinga <[email protected]>
This way is more consistent across the existing codebase Signed-off-by: Frank Elsinga <[email protected]>
Reasoning is, that it seems a bit more readable and browser support is there: https://caniuse.com/mdn-css_types_color_rgb_alpha_parameter Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
Signed-off-by: Frank Elsinga <[email protected]>
…n signal Signed-off-by: Frank Elsinga <[email protected]>
added stylelint-scss to the plugins Signed-off-by: Frank Elsinga <[email protected]>
TODO find out if this works
Reason:
for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array
.forEach is superiour to for..of due to Polyfills and other issues
Signed-off-by: Frank Elsinga <[email protected]>
gulpfile.js is the odd one out.
- only things that modern browsers use are getting delivered are listed as dependencys. - polyfills/build tooling is listed as below the other Dependencies, because while included in prod, they are only delivered to a minority of users
Co-authored-by: octycs <[email protected]>
Co-authored-by: octycs <[email protected]>
Co-authored-by: octycs <[email protected]>
CommanderStorm
force-pushed
the
js-scss-reformttings
branch
from
f93cd61 to
35a5c31
Compare
These are the changes to the js/scss files, to make #112 more reviewable