Skip to content

Commit

Permalink
[TASK] Update invalid test data providers
Browse files Browse the repository at this point in the history
Backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83155
to TYPO3 v12.

PHPUnit 10.5.18 introduces deprecation warning due to
use of non-matching parameter names with data providers,
introduced by sebastianbergmann/phpunit#5812.

This patch backports changes that were made for PHPUnit v11 support,
which also addresses these kind of deprecation warnings too.

Resolves: #103634
Related: #103222
Releases: 12.4
Change-Id: Ia9a1f7c5d62894dc80b3d1f9b465fb488b3250fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83788
Tested-by: Anja Leichsenring <[email protected]>
Reviewed-by: Anja Leichsenring <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
Tested-by: core-ci <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
  • Loading branch information
lolli42 authored and sbuerk committed Apr 15, 2024
1 parent be01b73 commit 54d40e2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Tests/Functional/Service/RedirectServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -920,15 +920,15 @@ public static function regExpRedirectsWithArgumentMatchesWithSimilarRegExpWithou
{
// Regression test for https://forge.typo3.org/issues/101191
yield '#1 Non-query argument regex redirect not respecting get arguments before query-argument regex does not match before query-argument regex' => [
'dataSet' => __DIR__ . '/Fixtures/RegExp/case1.csv',
'importDataSet' => __DIR__ . '/Fixtures/RegExp/case1.csv',
'url' => 'https://acme.com/foo/lightbar.html?type=101',
'statusCode' => 301,
'redirectUid' => 2,
'targetUrl' => 'https://acme.com/page3?type=101',
];

yield '#2 Non-query argument regex redirect respecting get arguments before query-argument regex does not match before query-argument regex' => [
'dataSet' => __DIR__ . '/Fixtures/RegExp/case2.csv',
'importDataSet' => __DIR__ . '/Fixtures/RegExp/case2.csv',
'url' => 'https://acme.com/foo/lightbar.html?type=101',
'statusCode' => 301,
'redirectUid' => 2,
Expand All @@ -940,7 +940,7 @@ public static function regExpRedirectsWithArgumentMatchesWithSimilarRegExpWithou
// this case. For example missing trailing `$` or leaving the `respect_query_parameters` option unchecked would
// mitigate this.
yield '#3 To open non-query argument regex redirect respecting get arguments before query-argument regex proceeds query-argument regex' => [
'dataSet' => __DIR__ . '/Fixtures/RegExp/case3.csv',
'importDataSet' => __DIR__ . '/Fixtures/RegExp/case3.csv',
'url' => 'https://acme.com/foo/lightbar.html?type=101',
'statusCode' => 301,
'redirectUid' => 1,
Expand Down

0 comments on commit 54d40e2

Please sign in to comment.