Skip to content

Commit

Permalink
bootstrap: exclude link_jobs from check_ci_llvm! checks
Browse files Browse the repository at this point in the history
This option is largely there to help people to manage the memory usage
on their systems during the LLVM build. The linking phase is as usual
are the heaviest part of the build and if in an unlucky conincidence the
circumstances align to kick off N_CORES links at the same time, not even
hundreds of GiB of memory may suffice. It makes a lot of sense for
developers to set&forget this option unconditionally.

Not to mention, this option does not, in any way, affect the generated
code (at least as far as I know.) It really doesn’t matter what
option the CI build LLVM used here and/or if it matches with the user’s
configuration.

Finally, 0 actual link jobs implied by `download-ci-llvm` is guaranteed
to stay within the limits that are reasonable to set with this option.
  • Loading branch information
nagisa committed Jan 10, 2024
1 parent e927184 commit 837be0d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/bootstrap/src/core/config/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,6 @@ impl Config {
check_ci_llvm!(static_libstdcpp);
check_ci_llvm!(targets);
check_ci_llvm!(experimental_targets);
check_ci_llvm!(link_jobs);
check_ci_llvm!(clang_cl);
check_ci_llvm!(version_suffix);
check_ci_llvm!(cflags);
Expand Down

0 comments on commit 837be0d

Please sign in to comment.