Remove unnecessary .env vars from setup instructions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AWS_URL` and `AWS_POST_END_POINT` environment variables are now dynamically determined by the aws-sdk-php package. Setting these to any value will make the sdk automatically assume you are using a custom endpoint and prevent the use of accelerator,
andreia
approved these changes
Jan 5, 2023
|
Thank you @kerkness for this PR and for taking the time to investigate this! |
|
FWIW it might be worth adding those back and just mentioning that they are optional, i.e. should only be used if a customer is using a custom, non-aws endpoint. I could see the lack of documentation for those two env vars causing confusion for those who may be using a 3rd party object store. Definitely not the common case, but it's something to keep in mind. |
|
@stobrien89 @kerkness Yeah, added a note in #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS_URLandAWS_POST_END_POINTenvironment variables are now dynamically determined by the aws-sdk-php package. Setting these to any value will make the sdk automatically assume you are using a custom endpoint and prevent the use of accelerator,Fixes #14