Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Collisions #22

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Prevent Collisions #22

merged 4 commits into from
Jul 30, 2023

Conversation

kaptk2
Copy link
Contributor

@kaptk2 kaptk2 commented Jul 28, 2023

Sometimes when many files that have the same name are uploaded simultaneously a naming collision happens. This pull request uses the ULID helper that Laravel provides to prevent any chance of a name collision.

@andreia
Copy link
Member

andreia commented Jul 28, 2023

@kaptk2 Thank you for this contribution! :)
Could you please fix the coding style?

@kaptk2
Copy link
Contributor Author

kaptk2 commented Jul 29, 2023

@andreia you got it, sorry it was a new editor and I'm still getting used to it. Should be good to go now

@andreia
Copy link
Member

andreia commented Jul 30, 2023

@kaptk2 Thank you! :)

@andreia andreia merged commit 4154d0a into TappNetwork:master Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants