Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Laravel 11 #26

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update to Laravel 11 #26

merged 2 commits into from
Apr 5, 2024

Conversation

kaptk2
Copy link
Contributor

@kaptk2 kaptk2 commented Apr 4, 2024

No description provided.

@swilla swilla requested a review from andreia April 4, 2024 20:34
Copy link
Member

@andreia andreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep "illuminate/contracts" instead of "laravel/framework"?

@kaptk2
Copy link
Contributor Author

kaptk2 commented Apr 5, 2024

No, that package conflicts with Laravel 11, either laravel/framework or illuminate/contracts can be installed but not both.

@andreia
Copy link
Member

andreia commented Apr 5, 2024

No, that package conflicts with Laravel 11, either laravel/framework or illuminate/contracts can be installed but not both.

@kaptk2 Thank you for your prompt reply! :)
I apologize for being unclear, what I meant was using illuminate/contracts instead of laravel/framework

@kaptk2
Copy link
Contributor Author

kaptk2 commented Apr 5, 2024

Oh, yes. I see what you mean. I made the change and everything still works as it should

Copy link
Member

@andreia andreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaptk2 Thank you!

@andreia andreia merged commit 7d5487f into TappNetwork:master Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants