v10.2.4 => Release Notes for details resolves #256

TarekRaafat · Jul 7, 2021 · df24f24 · df24f24
1 parent 9fd1b16
commit df24f24
Show file tree

Hide file tree

Showing 17 changed files with 25 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -51,13 +51,13 @@ autoComplete.js is a simple, pure vanilla Javascript library progressively desig
 `JS`
 
 ```html
-<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].2/dist/autoComplete.min.js"></script>
+<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/autoComplete.min.js"></script>
 ```
 
 `CSS`
 
 ```html
-<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].2/dist/css/autoComplete.min.css">
+<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/css/autoComplete.min.css">
 ```
 #### Package Manager
 

diff --git a/dist/autoComplete.js b/dist/autoComplete.js
@@ -274,14 +274,11 @@
     }
   });
 
-  var getData = function getData(ctx) {
+  var getData = function getData(ctx, query) {
     return new Promise(function ($return, $error) {
-      var input, query, data;
-      input = ctx.input;
-      query = ctx.query;
+      var data;
       data = ctx.data;
       if (data.cache && data.store) return $return();
-      query = query ? query(input.value) : input.value;
       return new Promise(function ($return, $error) {
         if (typeof data.src === "function") {
           return data.src(query).then($return, $error);
@@ -475,7 +472,7 @@
       queryVal = ctx.query ? ctx.query(queryVal) : queryVal;
       condition = checkTrigger(queryVal, ctx.trigger, ctx.threshold);
       if (condition) {
-        return getData(ctx).then(function ($await_2) {
+        return getData(ctx, queryVal).then(function ($await_2) {
           try {
             if (ctx.feedback instanceof Error) return $return();
             findMatches(queryVal, ctx);

diff --git a/dist/autoComplete.js.gz b/dist/autoComplete.js.gz
diff --git a/dist/autoComplete.min.js b/dist/autoComplete.min.js
diff --git a/dist/autoComplete.min.js.gz b/dist/autoComplete.min.js.gz
diff --git a/docs/demo/index.html b/docs/demo/index.html
@@ -72,7 +72,7 @@
 	<meta name="msapplication-TileImage" content="/ms-icon-144x144.png">
 	<meta name="theme-color" content="#ffffff">
 	<link rel="stylesheet" type="text/css" media="screen"
-		href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].3/dist/css/autoComplete.min.css">
+		href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/css/autoComplete.min.css">
 	<!-- <link rel="stylesheet" type="text/css" media="screen" href="./css/autoComplete.css"> -->
 	<link rel="stylesheet" type="text/css" media="screen" href="./css/main.css">
 	<link href="https://fonts.googleapis.com/css?family=PT+Sans" rel="stylesheet">
@@ -150,7 +150,7 @@ <h4>mode</h4>
 			</div>
 		</footer>
 	</div>
-	<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].3/dist/autoComplete.min.js"></script>
+	<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/autoComplete.min.js"></script>
 	<!-- <script src="./js/autoComplete.js"></script> -->
 	<script src="./js/index.js"></script>
 </body>

diff --git a/docs/demo/js/autoComplete.js b/docs/demo/js/autoComplete.js
@@ -274,14 +274,11 @@
     }
   });
 
-  var getData = function getData(ctx) {
+  var getData = function getData(ctx, query) {
     return new Promise(function ($return, $error) {
-      var input, query, data;
-      input = ctx.input;
-      query = ctx.query;
+      var data;
       data = ctx.data;
       if (data.cache && data.store) return $return();
-      query = query ? query(input.value) : input.value;
       return new Promise(function ($return, $error) {
         if (typeof data.src === "function") {
           return data.src(query).then($return, $error);
@@ -475,7 +472,7 @@
       queryVal = ctx.query ? ctx.query(queryVal) : queryVal;
       condition = checkTrigger(queryVal, ctx.trigger, ctx.threshold);
       if (condition) {
-        return getData(ctx).then(function ($await_2) {
+        return getData(ctx, queryVal).then(function ($await_2) {
           try {
             if (ctx.feedback instanceof Error) return $return();
             findMatches(queryVal, ctx);

diff --git a/docs/demo/js/autoComplete.js.gz b/docs/demo/js/autoComplete.js.gz
diff --git a/docs/demo/js/autoComplete.min.js b/docs/demo/js/autoComplete.min.js
diff --git a/docs/demo/js/autoComplete.min.js.gz b/docs/demo/js/autoComplete.min.js.gz
diff --git a/docs/index.html b/docs/index.html
@@ -158,7 +158,7 @@
         src="//platform-api.sharethis.com/js/sharethis.js#property=5c213660c276020011d38212&product=inline-share-buttons"
         async="async"></script>
     <link rel="stylesheet"
-        href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].3/dist/css/autoComplete.min.css">
+        href="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/css/autoComplete.min.css">
 </head>
 
 <body>
@@ -209,7 +209,7 @@
             mustache: {
                 data: ["../package.json", {
                     minVersion: "10.2",
-                    version: "10.2.3"
+                    version: "10.2.4"
                 }]
             }
         }
@@ -224,7 +224,7 @@
     <script src="https://cdn.jsdelivr.net/npm/docsify-example-panels"></script>
     <script src="//cdn.jsdelivr.net/npm/codeblock-iframe@latest/dist/index.min.js"></script>
     <script src="//cdn.jsdelivr.net/npm/docsify-codeblock-iframe@latest/dist/index.min.js"></script>
-    <script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].3/dist/autoComplete.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@tarekraafat/[email protected].4/dist/autoComplete.min.js"></script>
 </body>
 
 </html>
diff --git a/docs/release-notes.md b/docs/release-notes.md
@@ -35,7 +35,10 @@ For more information on semantic versioning, please visit <http://semver.org/>.
 
 ***
 
-### v10.2.3 ✨
+### v10.2.4 ✨
+- 🎛️ Updated: Library code with minor optimizations (Thanks 👍 @folknor) #256
+
+### v10.2.3
 - 🔧 Fixed: `query` API issue (Thanks 👍 @folknor) #254
 
 ### v10.2.2

diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {
-  "version": "10.2.3",
+  "version": "10.2.4",
   "name": "@tarekraafat/autocomplete.js",
   "description": "Simple autocomplete pure vanilla Javascript library.",
   "keywords": [

diff --git a/src/controllers/dataController.js b/src/controllers/dataController.js
@@ -6,13 +6,11 @@ import search from "./searchController";
  *
  * @param {Object} ctx - autoComplete.js context
  */
-const getData = async (ctx) => {
-  let { input, query, data } = ctx;
+const getData = async (ctx, query) => {
+  const { data } = ctx;
 
   if (data.cache && data.store) return;
 
-  query = query ? query(input.value) : input.value;
-
   ctx.feedback = data.store = typeof data.src === "function" ? await data.src(query) : data.src;
 
   /**

diff --git a/src/controllers/listController.js b/src/controllers/listController.js
@@ -25,7 +25,7 @@ const feedback = (ctx, index) => {
  * @param {Object} ctx - autoComplete.js context
  */
 const render = (ctx) => {
-  let { resultsList, list, resultItem, feedback } = ctx;
+  const { resultsList, list, resultItem, feedback } = ctx;
   const { matches, results } = feedback;
 
   // Reset cursor

diff --git a/src/services/init.js b/src/services/init.js
@@ -9,7 +9,7 @@ import eventEmitter from "../helpers/eventEmitter";
  * @param {Object} ctx - autoComplete.js context
  */
 export default async function (ctx) {
-  let { placeHolder, resultsList } = ctx;
+  const { placeHolder, resultsList } = ctx;
 
   const parentAttrs = {
     role: "combobox",

diff --git a/src/services/start.js b/src/services/start.js
@@ -18,7 +18,7 @@ export default async function (ctx, q) {
   // Validate trigger condition
   if (condition) {
     // Get from source
-    await getData(ctx);
+    await getData(ctx, queryVal);
     // Check if data fetch failed
     if (ctx.feedback instanceof Error) return;
     // Find matching results to the query