generated from dannaward/create-ios-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #227 - 갤러리에서 바로 공유 구현 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonBaek12
reviewed
Oct 16, 2023
joonBaek12
reviewed
Oct 18, 2023
joonBaek12
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다~~👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
아이폰의 갤러리 혹은 파일 등에서 사진 공유 시 포포리 앱이 뜨도록.
이후 사진 추가 플로우 구현
PR Point
Share Extension을 사용해 구현 -> Share Extension에 대한 프로비저닝 파일 필요 (없으면 빌드 안됨)
SceneDelegate에서 구현한 부분 코드가 너무 더러워 수정이 필요합니다 감안해서 봐주세요!
스크린샷
<일반적인 사진 공유>
https://github.com/TeamPophory/pophory-iOS/assets/75093565/975fe490-14b8-429a-aca1-0b84a729826c
<미로그인 유저> -> 로그인 화면으로
https://github.com/TeamPophory/pophory-iOS/assets/75093565/b78fb7d0-48b4-4b74-895a-fed3b3a230c7
<업로드할 수 있는 최대 개수를 이미 업로드한 경우>
https://github.com/TeamPophory/pophory-iOS/assets/75093565/a34e5c62-2bb7-4976-92b7-f14daa96ff56
관련 이슈