[crystal/lucky] Fix tests and update dependencies #9380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce connection pool size to avoid connection errors like:
psycopg2.OperationalError: connection to server at "10.0.0.2", port
5432 failed: FATAL: sorry, too many clients already
joanhey
reviewed
Nov 5, 2024
| @@ -14,7 +14,7 @@ ENV LUCKY_ENV production | |||
|
|
|||
| RUN shards build bench --release --no-debug | |||
|
|
|||
| ENV DATABASE_URL postgres://benchmarkdbuser:benchmarkdbpass@tfb-database:5432/hello_world?initial_pool_size=56&max_idle_pool_size=56 | |||
| ENV DATABASE_URL postgres://benchmarkdbuser:benchmarkdbpass@tfb-database:5432/hello_world?initial_pool_size=10&max_idle_pool_size=10 | |||
There was a problem hiding this comment.
Sorry, only an small question !!
All are playing with different pool sizes for the databases.
But we are learning (all languages) witch one is better ???
There was a problem hiding this comment.
That's only a question for reflexion !!
So we can learn all together.
Nothing about this PR.
PD: try to manage the pool size relative to the CPU cores, server, ... and not hardcoded.
There was a problem hiding this comment.
No problem @joanhey 😄
I think the pool size is already per CPU core.
This was causing the runs to fail as it was making too many connections (new machine has more cores).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce connection pool size to avoid connection errors like: