Support proc-macro2/nightly #24
Merged
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not fully understanding this; do you mind expanding on it a bit? Thanks for submitting this PR; going to test it locally then will approve and ship an updated crate if all goes well. |
|
extern crate from call_site (including user-written ones) does not work for def_site because macro hygiene doesn't want spans from multiple places to be mixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23.
::darlingstyle paths only works withSpan::call_site().Note that tests fails with
proc_macro::__internal::with_sess() called before set_parse_sess()!ifproc- macro2/nightlyis enabled becauseproc_macro's apis cannot be called from non-proc-macro code.