Allow custom from_word and from_none behaviors in derived FromMeta impls #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
commented
Jan 22, 2025
This was previously used within darling_core for `with` fields, but is more broadly applicable.
TedDriggs
force-pushed
the
from_methods
branch
from
3d12e33 to
3eabf80
Compare
This allows overriding how FromMeta-deriving types handle shorthand declarations or being absent altogether. Previously, this was done using `with` on each field where the type was consumed, but that could cause attribute sprawl or inconsistent behavior when consuming the type. This commit includes validations to avoid conflicts for unit structs, newtype structs, and enums that use the `word` variant-level attribute. Fixes #320
TedDriggs
force-pushed
the
from_methods
branch
2 times, most recently
from
c22b366 to
3b8d28d
Compare
TedDriggs
force-pushed
the
from_methods
branch
from
3b8d28d to
18911bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320