Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:updated dependencies to use latest stable release #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore:updated dependencies to use latest stable release #11

wants to merge 4 commits into from

Conversation

sid995
Copy link

@sid995 sid995 commented Dec 15, 2020

  • Updated tailwindcss, autoprefixer, postcss to use latest stable release
  • New tailwindcss.config.js file according to tailwind docs

iamstiil
iamstiil requested changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@iamstiil iamstiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sid995,
thank you for the PR. These changes look fine, but since Tailwind expects the Node version to be above 12.13.0, can you also add the engines declaration to the package.json?

@sid995 sid995 requested a review from iamstiil December 17, 2020 01:58
iamstiil
iamstiil requested changes Dec 18, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@iamstiil iamstiil self-requested a review December 18, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamstiil iamstiil iamstiil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sid995 @iamstiil