Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ability summary feature to Order Hall #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ckaotik
Copy link
Contributor

@ckaotik ckaotik commented Nov 11, 2016

I would love to see this feature for the order hall. This is just a starting point, as there are some rough edges in the code.

  • C_Garrison.GetAllEncounterThreats is a nicely sorted list, but the order differs from the formerly used id order. I therefore added the mechanicsorter for WoD garrisons.
  • Above list includes the old 6.0 mechanics, which seems like a Blizzard bug to me. I therefore manually excluded them.
  • Mechanics include 3 "Boss" threats, which are mapped to the "specialization" of the followers. These are - of course - separate from the normal abilities.
  • I treated traits with minion companion bonuses as "racial" and traits granting flat out bonuses as "bonus". However, there are a lot more of these effects that are abilities instead of traits (see Wowhead)

Display either the mechanic or the countering ability, based on `GarrisonFollowerOptions`' `displayCounterAbilityInPlaceOfMechanic` value
@ckaotik
Copy link
Contributor Author

ckaotik commented Nov 11, 2016

I noticed that the API doesn't tell us about alternative counters. On a Shaman, "Minions" can be countered for example by "Chain Lightning" or "Lightning Shield". These abilities are not interchangable.
However the latter ability provides no counter information at all:
C_Garrison.GetFollowerAbilityCounterMechanicInfo(513) => nil
C_Garrison.GetFollowerAbilityInfo(513).counters => {}

I have no idea how to work around this :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant