-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for DOM access before document ready #62
Conversation
cc @ivmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks! :) |
Deploy preview for mistica-web ready! Built with commit f01a97a ✅ Preview: https://mistica-web-jyoape78i.vercel.app This pull request is being automatically deployed with vercel-action |
Deploy preview for mistica-web ready! Built with commit 8ef7ef0 ✅ Preview: https://mistica-web-r4rub4z46.vercel.app This pull request is being automatically deployed with vercel-action |
Deploy preview for mistica-web ready! Built with commit 19100a5 ✅ Preview: https://mistica-web-coopt2yy0.vercel.app This pull request is being automatically deployed with vercel-action |
Deploy preview for mistica-web ready! Built with commit d746a67 ✅ Preview: https://mistica-web-mexw4c1er.vercel.app This pull request is being automatically deployed with vercel-action |
Phew, sorry this took way too many iterations. |
Hm, not sure if you'd rather have me rebase at this point 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now 👍
I know this has been discussed previously as a WONTFIX, since good practices mandate that we load JS code at the bottom of the body element. However: