Add missing QEMU startup order option #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleone87
approved these changes
Jun 24, 2022
|
Is a new release already in sight? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #525, and implements the currently missing startup order option for QEMU VMs.
There is a prerequisite for this PR at Telmate/proxmox-api-go#182, which adds the required code in the API module. Of course, this will also require updating the imports in this repository, which is not included in this PR. I assume the maintainers would handle this chore on the next versioned release.
The code is not organized alphabetically in this module, so I put the added code in what seemed to be the most logical place, next to
onboot. Hopefully this is OK, but if not, feel free to make edits and move things around as needed.Everything is tested and working as expected on my end. The only exception is that the startup option cannot be nullified once it is set. As far as I can tell, this is a limitation of the Proxmox API.