Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http_headers, add hostpci resource #618

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

BenediktBertsch
Copy link
Contributor

Hey @mleone87,

I've tried to implement the new http_headers and also my previous PR for hostpci, but it seems like that adding hostpci devices is not working. In the tfstate is the hostpci existing, but not on the host.

created vm with hostpci:
image

tfstate:

            "hostpci": [
              {
                "host": "0000:01:00.1",
                "rombar": 0
              }
            ],

Using normal json with the proxmox api works, but not my implementation. Have I missed some other settings which have to be set?

@mleone87
Copy link
Collaborator

mleone87 commented Oct 8, 2022

let me check your PR locally and see! nice work btw!

@mleone87
Copy link
Collaborator

mleone87 commented Oct 9, 2022

@BenediktBertsch pull latest api and this now should work

@BenediktBertsch
Copy link
Contributor Author

@mleone87 thanks for fixing this issue in proxmox-api! Looks good and works locally.

@mleone87 mleone87 merged commit 21e1861 into Telmate:master Oct 9, 2022
@brutesque
Copy link

I'm trying to implement this. Do you have an example configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants