Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation and examples #948

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

hestiahacker
Copy link
Contributor

@hestiahacker hestiahacker commented Feb 26, 2024

This closes #932

  • Updated examples to use the new disks syntax
  • Added the cloudini_cdrom_storage (now a required argument) and boot order (to work around Cloud-init drive delete when cloning vm with cloud-init drive #901 until it is fixed)
  • Updated documentation on the cloud_init_disk to have a disks block in the example and point to the easier way to use cloud-init
  • Pointed to the example file in the cloud_init guide

@hestiahacker hestiahacker changed the title doc: Updated examples to use the new disks syntax Updating documentation and examples Feb 26, 2024
@Tinyblargon Tinyblargon added the type/documentation This issue/PR is mainly about documentation label Mar 13, 2024
disks {
scsi {
scsi0 {
disk {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new disk schema it should be like this:

cd {
  iso = "${local.iso_storage_pool}:${proxmox_cloud_init_disk.ci.id}
}

Not 100% sure what local.iso_storage_pool and proxmox_cloud_init_disk.ci.id are in this situation.

@Tinyblargon Tinyblargon marked this pull request as draft March 13, 2024 20:49
@hestiahacker hestiahacker marked this pull request as ready for review March 18, 2024 16:59
@hestiahacker
Copy link
Contributor Author

Thanks for the review and correction. I think it should be good to go now

@hestiahacker hestiahacker mentioned this pull request Mar 25, 2024
6 tasks
@TAAGECH9
Copy link

TAAGECH9 commented Apr 11, 2024

@Tinyblargon , do you think this PR could be merged 😄? I was struggling on my own with exactly the same issue and wanted to create a PR and then realized that there is already this PR open. Would be nice to have it in the codebase 🚀

@TAAGECH9
Copy link

@Tinyblargon ,that was quick 🔥. Thank you very much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation This issue/PR is mainly about documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0.1-rc1] docs out of date
3 participants