add mobilenet ssd example #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihui
requested changes
Oct 9, 2017
examples/ssd/ssdmobilenet.cpp
Outdated
|
|
||
| ncnn::Mat out; | ||
|
|
||
| for(int i=0;i<1;i++) |
nihui
requested changes
Oct 9, 2017
examples/ssd/ssdmobilenet.cpp
Outdated
| Object object; | ||
| for(int iw=0;iw<out.w;iw++) | ||
| { | ||
| auto value = out.data[iw+ih*out.w]; |
There was a problem hiding this comment.
out.w is always six, so it's fine to write const float* values = out.row(ih); and use values[0] values[1] .... instead of the following six conditions
do not use auto keyword
examples/ssd/ssdmobilenet.cpp
Outdated
| printf("\n"); | ||
|
|
||
| } | ||
| for(auto object : objects) |
There was a problem hiding this comment.
always prefer indexed for-loop over c++11 range-based for
nihui
approved these changes
Oct 10, 2017
nihui
requested changes
Oct 10, 2017
examples/ssd/ssdmobilenet.cpp
Outdated
| int img_w = raw_img.size().width; | ||
| mobilenet.load_param("mobilenet_ssd_voc_ncnn.param"); | ||
| mobilenet.load_model("mobilenet_ssd_voc_ncnn.bin"); | ||
| auto input_size = 300; |
examples/ssd/ssdmobilenet.cpp
Outdated
| { | ||
| Object object = objects.at(i); | ||
| if(object.prob > show_threshold) | ||
| cv::rectangle(raw_img,object.rec,cv::Scalar(255,0,0)); |
There was a problem hiding this comment.
It will be nice to have class-id and score text drawn besides rectangle only
src/layer/interp.cpp
Outdated
| @@ -25,13 +25,13 @@ Interp::Interp() | |||
|
|
|||
| Interp::~Interp() | |||
| { | |||
| } | |||
There was a problem hiding this comment.
interp.cpp file conflicts, please fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.