Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Use Poetry dependency groups for docs dependencies #484

Merged
merged 4 commits into from
Sep 1, 2022
Merged

👷 Use Poetry dependency groups for docs dependencies #484

merged 4 commits into from
Sep 1, 2022

Conversation

TeoZosa
Copy link
Owner

@TeoZosa TeoZosa commented Apr 2, 2022 •
edited
Loading

What

SSIA.

Why

Introduced in Poetry version 1.2.0, dependency groups are cleaner and improve compatibility with user projects' dependencies.

Note

Also fixes the broken documentation building workflow since Poetry version 1.2.0 now uninstalls extras dependencies on any install command that doesn't explicitly include them.

ex.,

  • poetry install --no-interaction --no-root --extras docs -vv will install the docs extras,
  • subsequently running poetry install --no-interaction -vv will uninstall the docs extras.

@TeoZosa TeoZosa added enhancement New feature or request build Changes that affect the build system or external dependencies labels Apr 2, 2022
@TeoZosa TeoZosa self-assigned this Apr 2, 2022
@TeoZosa TeoZosa force-pushed the build/use-poetry-dependency-groups branch 3 times, most recently from 24d798d to 9442883 Compare April 2, 2022 19:47
@TeoZosa TeoZosa marked this pull request as draft April 4, 2022 16:03
@TeoZosa TeoZosa force-pushed the build/use-poetry-dependency-groups branch from 230f030 to 679c319 Compare September 1, 2022 03:21
@TeoZosa TeoZosa marked this pull request as ready for review September 1, 2022 03:46
@TeoZosa
🚨 🔧 Export requirements files via --output flag
c536ded 
Fixes:
```
================================== log start ===================================
ERROR: Invalid requirement: 'Creating virtualenv structlog-sentry-logger in /home/runner/work/structlog-sentry-logger/structlog-sentry-logger/.venv' (from line 1 of requirements.txt)
Hint: It looks like a path. File 'Creating virtualenv structlog-sentry-logger in /home/runner/work/structlog-sentry-logger/structlog-sentry-logger/.venv' does not exist.

=================================== log end ====================================
```

see: python-poetry/poetry#6275
@TeoZosa
♻️ Migrate to long flags in poetry export commands
efe2a4e
@TeoZosa TeoZosa added bug Something isn't working and removed enhancement New feature or request labels Sep 1, 2022
@TeoZosa TeoZosa merged commit a0c6e7d into master Sep 1, 2022
@TeoZosa TeoZosa deleted the build/use-poetry-dependency-groups branch September 1, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TeoZosa TeoZosa

Labels
bug Something isn't working build Changes that affect the build system or external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TeoZosa