Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryFormatter becomes obsolete -> Remove it with .NET 8.0 #1033

Closed
vbreuss opened this issue Aug 25, 2023 · 2 comments · Fixed by #1034
Closed

BinaryFormatter becomes obsolete -> Remove it with .NET 8.0 #1033

vbreuss opened this issue Aug 25, 2023 · 2 comments · Fixed by #1034
Labels
area: core Issues that address the core abstractions & the wrappers state: ready to pick Issues that are ready for being worked on state: released Issues that are released type: enhancement Issues that propose new functionality

Comments

@vbreuss
Copy link
Member

vbreuss commented Aug 25, 2023

I tried executing the preview version of .NET 8.0 with System.IO.Abstractions and got the following test errors (see #1032)
image

The reason is, that the BinaryFormatter becomes obsolete.

I suggest to remove the support for Serialization under .NET8.0.
@vbreuss vbreuss added type: enhancement Issues that propose new functionality state: needs discussion Issues that need further discussion labels Aug 25, 2023
@fgreinacher
Copy link
Contributor

Finally they did it 😅

Yes, let's exclude it for the .NET 8 build!

@fgreinacher fgreinacher added state: ready to pick Issues that are ready for being worked on area: core Issues that address the core abstractions & the wrappers and removed state: needs discussion Issues that need further discussion labels Aug 25, 2023
@vbreuss vbreuss mentioned this issue Aug 25, 2023
Merged
@mergify mergify bot closed this as completed in #1034 Sep 12, 2023
mergify bot pushed a commit that referenced this issue Sep 12, 2023
@vbreuss
refactor: prepare serialization infrastructure for .NET 8+ (#1034)
475b8c1 
This fixes #1033:
As [BinaryFormatter becomes obsolete](https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md), remove the tests for serialization on .NET8.0 or greater. Also move the `Serialization` attribute behind a feature flag, which is currently always active, but will be disabled with .NET9.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

This is addressed in release v19.2.87.

@github-actions github-actions bot added the state: released Issues that are released label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues that address the core abstractions & the wrappers state: ready to pick Issues that are ready for being worked on state: released Issues that are released type: enhancement Issues that propose new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: prepare serialization infrastructure for .NET 8+ vbreuss/System.IO.Abstractions
2 participants
@fgreinacher @vbreuss