Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly thrown exception in Directory.CreateSymbolicLink #1026

Merged
merged 6 commits into from
Aug 25, 2023
Merged

fix: incorrectly thrown exception in Directory.CreateSymbolicLink #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20ae8f9
Remove incorrectly thrown exception when the target does not exist in…
vbtig Aug 22, 2023
81d8bec
Merge branch 'main' into topic/vb/fix-incorrectly-thrown-exception
vbreuss Aug 22, 2023
1bb0a27
Merge branch 'main' into topic/vb/fix-incorrectly-thrown-exception
vbreuss Aug 22, 2023
a299c50
Merge branch 'main' into topic/vb/fix-incorrectly-thrown-exception
vbreuss Aug 22, 2023
922ad60
Merge branch 'main' into topic/vb/fix-incorrectly-thrown-exception
vbreuss Aug 25, 2023
882888c
Merge branch 'main' into topic/vb/fix-incorrectly-thrown-exception
vbreuss Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ public override IFileSystemInfo CreateSymbolicLink(string path, string pathToTar
throw CommonExceptions.FileAlreadyExists(nameof(path));
}

var targetExists = Exists(pathToTarget);
if (!targetExists)
{
throw CommonExceptions.FileNotFound(pathToTarget);
}

mockFileDataAccessor.AddDirectory(path);
mockFileDataAccessor.GetFile(path).LinkTarget = pathToTarget;

Expand Down
6 changes: 3 additions & 3 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectorySymlinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,18 +184,18 @@ public void MockDirectory_CreateSymbolicLink_ShouldFailIfPathExists()
}

[Test]
public void MockDirectory_CreateSymbolicLink_ShouldFailIfTargetDoesNotExist()
public void MockDirectory_CreateSymbolicLink_ShouldNotFailIfTargetDoesNotExist()
{
// Arrange
var fileSystem = new MockFileSystem();
string path = XFS.Path(@"C:\Folder\foo");
string pathToTarget = XFS.Path(@"C:\Target");

// Act
var ex = Assert.Throws<FileNotFoundException>(() => fileSystem.Directory.CreateSymbolicLink(path, pathToTarget));
var fileSystemInfo = fileSystem.Directory.CreateSymbolicLink(path, pathToTarget);

// Assert
Assert.That(ex.Message.Contains(pathToTarget));
Assert.IsTrue(fileSystemInfo.Exists);
}

[Test]
Expand Down