refactor: make Execute non-static
#462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
commented
Feb 26, 2024
vbreuss
commented
Feb 26, 2024
vbreuss
commented
Feb 26, 2024
|
This is addressed in release v3.0.0. |
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions.FluentAssertions
Mar 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Testably.Abstractions.Interface](https://togithub.com/Testably/Testably.Abstractions) | `2.6.1` -> `3.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Interface)</summary> ### [`v3.0.0`](https://togithub.com/Testably/Testably.Abstractions/releases/tag/v3.0.0) #### Breaking Changes - Rename namespace from `Testably.Abstractions.Testing.FileSystemInitializer` to `Testably.Abstractions.Testing.Initializer` - Move static methods from `RandomProvider.Generator<T>` to `RandomProvider.Generator` - Remove `PathSystemBase` from `Testably.Abstractions.Interface` - Update `TestableIO.System.IO.Abstractions` to v21.0.2 and adapt interface according to the breaking change in [https://github.com/TestableIO/System.IO.Abstractions/pull/1104](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1104) - Make class `FileSystemWatcherMock` internal #### What's Changed - chore(deps): update testably.abstractions packages to v2.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/447](https://togithub.com/Testably/Testably.Abstractions/pull/447) - chore(deps): update dependency xunit to v2.6.6 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/449](https://togithub.com/Testably/Testably.Abstractions/pull/449) - chore(deps): update actions/cache action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/450](https://togithub.com/Testably/Testably.Abstractions/pull/450) - chore(deps): update dependency testableio.system.io.abstractions to v20.0.15 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/451](https://togithub.com/Testably/Testably.Abstractions/pull/451) - chore(deps): update nuget/setup-nuget action to v1.3.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/452](https://togithub.com/Testably/Testably.Abstractions/pull/452) - chore(deps): update microsoft/setup-msbuild action to v2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/453](https://togithub.com/Testably/Testably.Abstractions/pull/453) - chore(deps): update nuget/setup-nuget action to v2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/454](https://togithub.com/Testably/Testably.Abstractions/pull/454) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/455](https://togithub.com/Testably/Testably.Abstractions/pull/455) - chore(deps): update dependency microsoft.net.test.sdk to v17.9.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/456](https://togithub.com/Testably/Testably.Abstractions/pull/456) - chore(deps): update wandalen/wretry.action action to v1.4.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/457](https://togithub.com/Testably/Testably.Abstractions/pull/457) - chore(deps): update dependency coverlet.collector to v6.0.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/459](https://togithub.com/Testably/Testably.Abstractions/pull/459) - chore(deps): update xunit-dotnet monorepo by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/458](https://togithub.com/Testably/Testably.Abstractions/pull/458) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/461](https://togithub.com/Testably/Testably.Abstractions/pull/461) - refactor: make `Execute` non-static by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/462](https://togithub.com/Testably/Testably.Abstractions/pull/462) - refactor: fix sonar issues by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/463](https://togithub.com/Testably/Testably.Abstractions/pull/463) - refactor: use non-static OS selector in tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/464](https://togithub.com/Testably/Testably.Abstractions/pull/464) - chore(deps): update wandalen/wretry.action action to v1.4.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/465](https://togithub.com/Testably/Testably.Abstractions/pull/465) - chore(deps): update dependency microsoft.codeanalysis.csharp to v4.9.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/466](https://togithub.com/Testably/Testably.Abstractions/pull/466) - refactor: cleanup inconsistent line endings by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/467](https://togithub.com/Testably/Testably.Abstractions/pull/467) - chore(deps): update dependency minver to v5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/469](https://togithub.com/Testably/Testably.Abstractions/pull/469) - chore(deps): update wandalen/wretry.action action to v1.4.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/470](https://togithub.com/Testably/Testably.Abstractions/pull/470) - chore(deps): update wandalen/wretry.action action to v1.4.8 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/472](https://togithub.com/Testably/Testably.Abstractions/pull/472) - chore(deps): update dependency testableio.system.io.abstractions to v20.0.28 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/475](https://togithub.com/Testably/Testably.Abstractions/pull/475) - chore(deps): update softprops/action-gh-release action to v2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/473](https://togithub.com/Testably/Testably.Abstractions/pull/473) - feat: add statistics by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/474](https://togithub.com/Testably/Testably.Abstractions/pull/474) - fix: errors from static code analysis by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/477](https://togithub.com/Testably/Testably.Abstractions/pull/477) - refactor: replace the dictionary in the statistics with an array by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/478](https://togithub.com/Testably/Testably.Abstractions/pull/478) - docs: improve readme examples by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/480](https://togithub.com/Testably/Testably.Abstractions/pull/480) - chore(deps): update wandalen/wretry.action action to v1.4.9 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/481](https://togithub.com/Testably/Testably.Abstractions/pull/481) - chore(deps): update actions/checkout digest to [`9bb5618`](https://togithub.com/Testably/Testably.Abstractions/commit/9bb5618) by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/483](https://togithub.com/Testably/Testably.Abstractions/pull/483) - chore(deps): update actions/checkout digest to [`b4ffde6`](https://togithub.com/Testably/Testably.Abstractions/commit/b4ffde6) by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/484](https://togithub.com/Testably/Testably.Abstractions/pull/484) - chore(deps): update dependency coverlet.collector to v6.0.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/485](https://togithub.com/Testably/Testably.Abstractions/pull/485) - chore(deps): update wandalen/wretry.action action to v1.4.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/486](https://togithub.com/Testably/Testably.Abstractions/pull/486) - feat: add Api approval tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/482](https://togithub.com/Testably/Testably.Abstractions/pull/482) - refactor: normalize line endings using `.gitattributes` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/487](https://togithub.com/Testably/Testably.Abstractions/pull/487) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/488](https://togithub.com/Testably/Testably.Abstractions/pull/488) - feat: add global.json to use latest SDK by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/479](https://togithub.com/Testably/Testably.Abstractions/pull/479) - chore(deps): update dependency dotnet-sdk to v8.0.202 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/489](https://togithub.com/Testably/Testably.Abstractions/pull/489) - chore(deps): update dependency dotnet-sdk to v8.0.203 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/490](https://togithub.com/Testably/Testably.Abstractions/pull/490) - chore: Limit "renovate" to run only weekly by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/491](https://togithub.com/Testably/Testably.Abstractions/pull/491) - feat: add statistics for property access by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/493](https://togithub.com/Testably/Testably.Abstractions/pull/493) - fix: Install .NET on code upload step by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/494](https://togithub.com/Testably/Testably.Abstractions/pull/494) - refactor: switch to sonar automatic analysis by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/496](https://togithub.com/Testably/Testably.Abstractions/pull/496) - fix: sonar issues after activating automatic analysis by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/495](https://togithub.com/Testably/Testably.Abstractions/pull/495) - refactor: adapt and execute cleanup by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/498](https://togithub.com/Testably/Testably.Abstractions/pull/498) - fix: use latest stryker.net version by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/497](https://togithub.com/Testably/Testably.Abstractions/pull/497) - refactor: adapt ReSharper File Layout to avoid Sonar issues during cleanup by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/499](https://togithub.com/Testably/Testably.Abstractions/pull/499) - fix: correctly match statistic paths by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/500](https://togithub.com/Testably/Testably.Abstractions/pull/500) - refactor: extract extension methods from `Execute` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/501](https://togithub.com/Testably/Testably.Abstractions/pull/501) - feat: avoid arbitrary statistic calls by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/502](https://togithub.com/Testably/Testably.Abstractions/pull/502) - coverage: add tests for `FileSystemWatcher` events by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/503](https://togithub.com/Testably/Testably.Abstractions/pull/503) - fix: avoid statistic registrations on complex initializations by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/505](https://togithub.com/Testably/Testably.Abstractions/pull/505) - refactor: exclude obsolete methods from code coverage by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/504](https://togithub.com/Testably/Testably.Abstractions/pull/504) - chore!: update `TestableIO.System.IO.Abstractions` to v21.0.2 by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/506](https://togithub.com/Testably/Testably.Abstractions/pull/506) - feat: remove obsolete class `PathSystemBase` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/507](https://togithub.com/Testably/Testably.Abstractions/pull/507) - refactor: simplify changing the test settings by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/508](https://togithub.com/Testably/Testably.Abstractions/pull/508) - chore(deps): update dependency nunit.analyzers to v4.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/510](https://togithub.com/Testably/Testably.Abstractions/pull/510) - chore(deps): update dependency newtonsoft.json to v13.0.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/509](https://togithub.com/Testably/Testably.Abstractions/pull/509) - feat: include skip message for long running tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/511](https://togithub.com/Testably/Testably.Abstractions/pull/511) - docs: add license scan report and status by [@​fossabot](https://togithub.com/fossabot) in [https://github.com/Testably/Testably.Abstractions/pull/512](https://togithub.com/Testably/Testably.Abstractions/pull/512) - feat: enable/disable brittle tests via test settings by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/514](https://togithub.com/Testably/Testably.Abstractions/pull/514) - fix: add lock file to directory cleaner by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/515](https://togithub.com/Testably/Testably.Abstractions/pull/515) - feat: add retry also to .NET Framework tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/517](https://togithub.com/Testably/Testably.Abstractions/pull/517) - feat: add `Meziantou.Analyzer` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/519](https://togithub.com/Testably/Testably.Abstractions/pull/519) - fix: disable build warning CS0436 in `Testably.Abstractions.Testing.Tests` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/516](https://togithub.com/Testably/Testably.Abstractions/pull/516) - refactor: remove `.ConfigureAwait` in tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/520](https://togithub.com/Testably/Testably.Abstractions/pull/520) - refactor: dispose of `ManualResetEventSlim` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/518](https://togithub.com/Testably/Testably.Abstractions/pull/518) - coverage: avoid skipping brittle tests in `FileSystemWatcher` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/521](https://togithub.com/Testably/Testably.Abstractions/pull/521) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.2.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/523](https://togithub.com/Testably/Testably.Abstractions/pull/523) - chore(deps): update dependency meziantou.analyzer to v1.0.758 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/524](https://togithub.com/Testably/Testably.Abstractions/pull/524) - fix: do not adjust LastAccessTime in `FileStream.EndRead` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/522](https://togithub.com/Testably/Testably.Abstractions/pull/522) - coverage: add missing tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/525](https://togithub.com/Testably/Testably.Abstractions/pull/525) - feat: collect coverage information for .NET Framework by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/526](https://togithub.com/Testably/Testably.Abstractions/pull/526) - fix: Report Generator does not support mixing .NET Framework and .NET Core by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/527](https://togithub.com/Testably/Testably.Abstractions/pull/527) - feat: Enable Stryker CI-Build by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/528](https://togithub.com/Testably/Testably.Abstractions/pull/528) - fix: support search pattern with subdirectories when enumerating a directory by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/529](https://togithub.com/Testably/Testably.Abstractions/pull/529) - fix: support three-character file extension as search pattern in .NET Framework by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/530](https://togithub.com/Testably/Testably.Abstractions/pull/530) - fix: dependency error in release.yml by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/531](https://togithub.com/Testably/Testably.Abstractions/pull/531) - fix: catch `ObjectDisposedException` in tests by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/532](https://togithub.com/Testably/Testably.Abstractions/pull/532) - refactor: catch `ObjectDisposedException` in `TimerMockTests` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/533](https://togithub.com/Testably/Testably.Abstractions/pull/533) - fix: use latest Stryker version in release pipeline by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/534](https://togithub.com/Testably/Testably.Abstractions/pull/534) #### New Contributors - [@​fossabot](https://togithub.com/fossabot) made their first contribution in [https://github.com/Testably/Testably.Abstractions/pull/512](https://togithub.com/Testably/Testably.Abstractions/pull/512) **Full Changelog**: Testably/Testably.Abstractions@v2.6.1...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Valentin Breuß <[email protected]>
](https://renovatebot.com){kind=link}
|
This is addressed in release v3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite to #460 refactor how to handle OS-specific use cases:
Executeclass non-static and a property of theMockFileSystemExecutemethods to use the property on theMockFileSysteminsteadStringComparisonModefromInMemoryLocationto theExecuteclass