-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Tweak default colors for RichHandler #2825
Labels
accepted
Task was accepted
Comments
Sure. I would accept a PR for that... |
9 tasks
I hope we solved your problem. If you like using Rich, you might also enjoy Textual |
mhxion
added a commit
to uhd-urz/elAPI
that referenced
this issue
Aug 27, 2024
Typer already depends on rich. To use the latest rich version, we define 'rich = "^13.8.0"' ourselves. Rich v13.8.0 comes with some important fixes that concern us. See: https://github.com/Textualize/rich/releases/tag/v13.8.0, Textualize/rich#2825.
mhxion
added a commit
to uhd-urz/elAPI
that referenced
this issue
Aug 27, 2024
Typer already depends on rich. To use the latest rich version, we define 'rich = "^13.8.0"' ourselves. Rich v13.8.0 comes with some important fixes that concern us. See: https://github.com/Textualize/rich/releases/tag/v13.8.0, Textualize/rich#2825.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, first of all, thank you for rich! I use it in pretty much all my projects.
I have a very minor suggestion regarding the default colors for logging levels.
I know we can customize them using themes (and I already do!).
I use mostly info/warning/error levels for logging, and depending on the terminal used, warnings and errors render almost identically.
When googling "Python colored logs", the top solutions (in my case) use yellow-ish for warnings and red for errors.
Granted, many of the top results use
coloredlogs
, but in any case I see:So I was wondering if you would be willing to tweak the default
'logging.level.warning'
to something closer to yellow, to be more in line with this, and give a bit more distinction to warnings and errors.Anyway, I am perfectly happy with customization through themes!
The text was updated successfully, but these errors were encountered: