-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 13 ASLoadFrameworkInitializer dead lock fix on running unit test #2032
Xcode 13 ASLoadFrameworkInitializer dead lock fix on running unit test #2032
Conversation
This comment has been minimized.
This comment has been minimized.
May i ask whats blocking progress here? Meanwhile Xcode 13.1 is just around the corner. |
I'm also curious too |
Anything needed to be done to have this merged? |
Any progress? |
@nguyenhuy @rcancro please have a look here 🙏 |
With a breakpoint in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! Sorry for the delay!
TextureGroup#2032) * replace destructor for after main execute * separate ASLoadFrameworkInitializer between constructor and destructor * AS_EXTERN -> ASDK_EXTERN * initialSetNeedsDisplayCount should be called once on iOS 15 * Loaded node of contentsScale must be 2.0 on layer backed * initialSetNeedsDisplayCount must called once
Separated before & after main for fix dead lock issue running unit test
a366b40
initialSetNeedsDisplayCount should be called once
28d8706
Loaded node of contentsScale must be 2.0 on layer backed
01e47e3
Creating layers (not created via a UIView), node need to set their scale manually. Usually this is just layer.contentsScale = [[UIScreen mainScreen] scale].