fix: solve clip planes deletAll infinite loop

ThatOpen · Jun 22, 2024 · 8e40173 · 8e40173
1 parent c662905
commit 8e40173
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.0.14",
+  "version": "2.0.15",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/core/Clipper/example.ts b/packages/core/src/core/Clipper/example.ts
@@ -110,7 +110,11 @@ clipper.enabled = true;
 
   */
 
-container.ondblclick = () => clipper.create(world);
+container.ondblclick = () => {
+  if (clipper.enabled) {
+    clipper.create(world);
+  }
+};
 
 /* MD
 
@@ -128,7 +132,9 @@ container.ondblclick = () => clipper.create(world);
 
 window.onkeydown = (event) => {
   if (event.code === "Delete" || event.code === "Backspace") {
-    clipper.delete(world);
+    if (clipper.enabled) {
+      clipper.delete(world);
+    }
   }
 };
 

diff --git a/packages/core/src/core/Clipper/index.ts b/packages/core/src/core/Clipper/index.ts
@@ -189,8 +189,6 @@ export class Clipper
 
   /** {@link Createable.create} */
   create(world: World) {
-    if (!this.enabled) return;
-
     const casters = this.components.get(Raycasters);
     const caster = casters.get(world);
 
@@ -227,7 +225,6 @@ export class Clipper
    * found under the cursor will be deleted.
    */
   delete(world: World, plane?: SimplePlane) {
-    if (!this.enabled) return;
     if (!plane) {
       plane = this.pickPlane(world);
     }