Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moved mapbox to peer dependencies #265

Merged
merged 2 commits into from
Jan 16, 2024
Merged

feat: Moved mapbox to peer dependencies #265

merged 2 commits into from
Jan 16, 2024

Conversation

HoyosJuan
Copy link
Member

Description

This addresses issue #263.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan linked an issue Jan 16, 2024 that may be closed by this pull request
Remove direct mapbox-gl dependency #263
Closed
@HoyosJuan HoyosJuan merged commit 91d69a9 into ThatOpen:main Jan 16, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@HoyosJuan HoyosJuan deleted the 263-remove-direct-mapbox-dependency branch January 16, 2024 19:26
@HoyosJuan HoyosJuan added bug Something isn't working feature Something new that we could do and removed bug Something isn't working labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Something new that we could do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove direct mapbox-gl dependency
1 participant
@HoyosJuan