fix: prevent empty colors array in get method

ThatOpen · Feb 13, 2024 · 040aa8a · 040aa8a
1 parent 469d21a
commit 040aa8a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bim-fragment",
-  "version": "1.3.10",
+  "version": "1.3.11",
   "description": "3D BIM Geometry API",
   "main": "src/index.js",
   "scripts": {

diff --git a/resources/fragment.js b/resources/fragment.js
@@ -4230,6 +4230,7 @@ let Fragment$1 = class Fragment {
             if (this.mesh.instanceColor) {
                 const color = new THREE.Color();
                 this.mesh.getColorAt(id, color);
+                colorsArray.push(color);
             }
         }
         const colors = colorsArray.length ? colorsArray : undefined;

diff --git a/src/fragment.ts b/src/fragment.ts
@@ -89,6 +89,7 @@ export class Fragment {
       if (this.mesh.instanceColor) {
         const color = new THREE.Color();
         this.mesh.getColorAt(id, color);
+        colorsArray.push(color);
       }
     }
     const colors = colorsArray.length ? colorsArray : undefined;