Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2365 #2371

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix #2365 #2371

merged 1 commit into from
Nov 13, 2024

Conversation

Drullkus
Copy link
Contributor

@Drullkus Drullkus commented Nov 13, 2024

Fixes Clouds not generating around Silver Dungeons, which is a non-deterministic worldgen bug caused by incomplete generation such as closing the save or structure being on edge of a passerby's chunk-loading.

There is also an additional measure to skip creation of Cloud structure pieces, if they will not place any blocks.

Fixes #2365

Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bconlon1 bconlon1 merged commit 305485a into 1.21.1-develop Nov 13, 2024
2 checks passed
@bconlon1 bconlon1 deleted the feat/drullkus/SilverCloudFix branch November 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug: Silver Dungeons not spawning with clouds sometimes or always im not really sure
2 participants