Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, test: Fit Topological Sort algorithm to contributing guidelines #2835

Merged
merged 10 commits into from
Nov 1, 2024
Merged

docs, test: Fit Topological Sort algorithm to contributing guidelines #2835

merged 10 commits into from
Nov 1, 2024

Conversation

HarshilShah1804
Copy link
Contributor

Description of Change

Added namespaces and updated existing documentation and tests to fit current guidelines

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes Oct 19, 2024
View reviewed changes
graph/topological_sort.cpp Outdated Show resolved Hide resolved
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 21, 2024
realstealthninja
realstealthninja requested changes Oct 22, 2024
View reviewed changes
graph/topological_sort.cpp Show resolved Hide resolved
graph/topological_sort.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made labels Oct 31, 2024
@realstealthninja realstealthninja merged commit 85d62bb into TheAlgorithms:master Nov 1, 2024
6 checks passed
@HarshilShah1804 HarshilShah1804 deleted the Harshil branch November 2, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarshilShah1804 @realstealthninja