-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support llvm-15 for inkwell #365
Conversation
As mentioned in the issue, it's not just as simple as updating the Cargo.toml :) Off the top of my head, there's at least a few more things needed:
And probably more.. |
This macro still errors out. What is it looking for? $ cargo build
Compiling inkwell v0.1.0 (/run/media/adityak/tb_half/inkwell)
error: One of the LLVM feature flags must be provided: llvm4-0 llvm5-0 llvm6-0 llvm7-0 llvm8-0 llvm9-0 llvm10-0 llvm11-0 llvm12-0 llvm13-0 llvm14-0 llvm15-0
--> src/lib.rs:97:9
|
97 | compile_error!(concat!("One of the LLVM feature flags must be provided: ", $($all, " "),*));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
108 | assert_unique_used_features! {"llvm4-0", "llvm5-0", "llvm6-0", "llvm7-0", "llvm8-0", "llvm9-0", "llvm10-0", "llvm11-0", "llvm12-0", "llvm13-0", "llvm14-0", "llvm15-0"}
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation |
Need to specify an llvm version feature flag |
Can you point to the code where I need to specify that? |
|
...And add llvm15-0 as supported version to README 😀 |
But there is a problem. LLVM is moving to opaque pointers. In llvm 15 non-opaque pointer access may already have been removed from API |
Opaque ptrs are still optional in LLVM15, we can figure out come the LLVM16 release |
Fixed |
TODO: Provide equivalent traits for llvm.15
@aditya-solana I've finished support in this PR. Please check if you'd like to add anything. |
@hedgar2017 |
@aditya-solana I think you may close this PR. We'll wait until the CI is fixed and then merge mine. |
closing |
Description
Added llvm-15 support
#359
Issues
Still has build errors.